Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

banish CentOS 5 #1984

Merged
merged 1 commit into from
Oct 27, 2019
Merged

banish CentOS 5 #1984

merged 1 commit into from
Oct 27, 2019

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Oct 23, 2019

Overdue. CentOS 5 has been idle since we dropped Node 6. Let's get rid of any trace of it as a cathartic experience.

On top of the changes to the repo, these machines will need to be unprovisioned and removed from jenkins:

  • test-digitalocean-centos5-x86-1
  • test-softlayer-centos5-x64-1
  • test-softlayer-centos5-x64-2
  • release-digitalocean-centos5-x64-1
  • release-softlayer-centos5-x86-1

iojs+release will need centos5-x64 and centos5-x86 removed from it.

The configs for these jobs in ci.nodejs.org reference "centos5" in some form, presumably just removing the label:

  • archive-node-test-commit-unified
  • archive-node-test-known-issues
  • citgm-abi-smoker
  • citgm-abi-smoker-forward-compat
  • citgm-smoker-private
  • citgm-smoker-rebuild
  • citgm-smoker-yarn
  • libuv-test-pipeline
  • node-test-commit-linux
  • node-test-napi-modules-citgm
  • node-test-napi-modules-citgm-v8.x
  • refack-test-commit-linux

@richardlau
Copy link
Member

* citgm-abi-smoker

* citgm-abi-smoker-forward-compat

* citgm-smoker-rebuild

* citgm-smoker-yarn

These four jobs have been disabled nodejs/citgm#741 (comment) and can probably be removed given nobody has complained.

* citgm-smoker-private

I can't see this job on ci.nodejs.org.

@rvagg
Copy link
Member Author

rvagg commented Oct 23, 2019

* citgm-smoker-private

I can't see this job on ci.nodejs.org.

Because it's super-secret-private. Access only by nodejs*jenkins-admins and nodejs*security. I don't know if it's used still during security releases.

@sam-github
Copy link
Contributor

Running citgm is not part of the documented sec release process, though I guess we would run it if we were concerned about the impact of a change.

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -12,7 +12,6 @@ def buildExclusions = [
// Machine Label, Build Type, Node Version

// Linux -------------------------------------------------
[ /^centos5/, anyType, gte(8) ],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to make sure that all jobs referencing these nodes are updated before committing this otherwise they will start scheduling jobs against them (since this script is "don't allow if" so if the line is removed it is allowed).

@rvagg
Copy link
Member Author

rvagg commented Oct 26, 2019

Have done the Jenkins bit first, removed from:

  • archive-libuv-test-pipeline
  • archive-node-test-commit-unified
  • archive-node-test-known-issues
  • citgm-abi-smoker
  • citgm-abi-smoker-forward-compat
  • citgm-smoker-private
  • citgm-smoker-rebuild
  • citgm-smoker-yarn
  • node-test-commit-linux
  • node-test-napi-modules-citgm
  • node-test-napi-modules-citgm-v8.x

and in ci-release:

  • check-java-version
  • iojs+release
  • iojs+release-mdawson-major
  • iojs+release-mdawson-osx
  • iojs+release-mdawson-test-centosppc
  • iojs+release-mdawson-test
  • iojs+release-new-osx-temp
  • iojs+release-ppcle-only

no traces in job config files now

@rvagg rvagg force-pushed the rvagg/banish-centos5 branch from 5248e53 to 24c7bc8 Compare October 27, 2019 11:19
@rvagg rvagg merged commit b5c2a57 into master Oct 27, 2019
@rvagg rvagg deleted the rvagg/banish-centos5 branch October 27, 2019 11:19
@richardlau richardlau mentioned this pull request Apr 22, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants